Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-#108: inlining all posts card(shimmer cards) #332

Closed
wants to merge 1 commit into from
Closed

Bug-#108: inlining all posts card(shimmer cards) #332

wants to merge 1 commit into from

Conversation

Chelseasingla1
Copy link
Contributor

@Chelseasingla1 Chelseasingla1 commented May 21, 2024

Summary

Inlining posts with full-width

Description

This PR is according to changes made in post-card-skeleton to make padding properly and making changes to handle properly in all the screens, added pr-4 for padding, gap-1, gap-2 for spacing along with responsiveness.

Images

image

Issue(s) Addressed

Closes #108

Prerequisites

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 5:48pm
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 5:48pm

Copy link

Hello Chelseasingla1 Thank you for your PR. Unfortunately, it doesn't meet our quality checks.

Please ensure you follow our contribution guidelines. The PR title should match the required format.

For example, it should be like: fix-#124: Added responsiveness to the Home page screen.

If you have any query kindly check our contributor guidelines.

1 similar comment
Copy link

Hello Chelseasingla1 Thank you for your PR. Unfortunately, it doesn't meet our quality checks.

Please ensure you follow our contribution guidelines. The PR title should match the required format.

For example, it should be like: fix-#124: Added responsiveness to the Home page screen.

If you have any query kindly check our contributor guidelines.

@Chelseasingla1 Chelseasingla1 changed the title Bug- #108 inlining all posts card with skeleton Bug- #108 inlining all posts card(shimmer cards) May 21, 2024
Copy link

Hello Chelseasingla1 Thank you for your PR. Unfortunately, it doesn't meet our quality checks.

Please ensure you follow our contribution guidelines. The PR title should match the required format.

For example, it should be like: fix-#124: Added responsiveness to the Home page screen.

If you have any query kindly check our contributor guidelines.

@Chelseasingla1 Chelseasingla1 changed the title Bug- #108 inlining all posts card(shimmer cards) Bug-#108: inlining all posts card(shimmer cards) May 21, 2024
Copy link

Hello Chelseasingla1 Thank you for your PR. Unfortunately, it doesn't meet our quality checks.

Please ensure you follow our contribution guidelines. The PR title should match the required format.

For example, it should be like: fix-#124: Added responsiveness to the Home page screen.

If you have any query kindly check our contributor guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] All posts card is not inline with the skeleton (shimmer card)
1 participant