feat-#301: Now Error messages are displaying below input field as message error instead of toast error. #303
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@krishnaacharyaa sir what is wrong with the PR title or with commit message? |
|
@0xmohitsen Use feat instead or refactor |
|
@Sukomal07 need your review |
There was a problem hiding this comment.
you just increase database call. You don't need to call DB again and again.
There was a problem hiding this comment.
Yeah correct. I will make it in one db call.
0xmohitsen
changed the title
…d input field instead of toastifying + correction in margin between signup input field (replaced mb-3 to mb-2)
0xmohitsen
force-pushed
the
fix-wanderlust
branch
from
b2d7e98 to
32feccd
Compare
Rebased with feat but still PR title check is failed. |
Forget it |
|
@Sukomal07 good to merge? |
@krishnaacharyaa sir add the gssoc + level label too. |
|
@krishnaacharyaa yes sir |
| passwordRegex, | ||
| 'Password must be contains at least one uppercase and one lowercase and one digit and one special character' | ||
| ), | ||
| .min(1, { message: 'Confirm Password is required'}), | ||
| }) |
There was a problem hiding this comment.
Why is 1? and why are we completely changing this? passwordRegex is totally removed?
There was a problem hiding this comment.
Why is 1? and why are we completely changing this? passwordRegex is totally removed?
Given 1 so that if it is empty then we can show error message "Confirm Password is required".
And if it has at least 1 charactor in confirmPassword field it should check with password field string that confirmPassword and password field string matches or not so in this case it will show error message "Confirm Password does not match" if strings do not match.
And if confirmPassword string matches with password string then it won't show error message.
Password regex is removed (from confirmPassword field) because it does not require here. We are already added regex to password field so it is obivous that user will have to fill same password string in confirmPassword. We don't need to tell explicity for this field.
There was a problem hiding this comment.
Good attention to details!
Summary
This PR aims to achieve the #301 proposed enhancement for better user experience.
Description
This PR basically made correction in both frontend and backend.
Backend :-
Frontend :-
Issue(s) Addressed
Closes : #301
Prerequisites