Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance-#301: Now Error messages are displaying below input field as message error instead of toast error. #302

Closed

Conversation

0xmohitsen
Copy link
Contributor

Summary

This PR aims to achieve the #301 proposed enhancement for better user experience.

Description

This PR basically made correction in both frontend and backend.

Backend :-

  1. Changed in /signup handler
  2. Added some constant user response messages

Frontend :-

  1. Added setError method to display the error message below the input fields instead of toast error in both signin and signup page.
  2. Removed unnecessary validation from types.ts file in signup schema for confirmPassword.

Issue(s) Addressed

Closes : #301

Prerequisites

Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 2:35pm
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 2:35pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Error messages should come below input field as message error instead of toast error.
1 participant