fix-#257: Hide and visible in password to improve UI #299
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
GOURAVSINGH19
changed the title
GOURAVSINGH19
changed the title
GOURAVSINGH19
changed the title
GOURAVSINGH19
changed the title
GOURAVSINGH19
changed the title
GOURAVSINGH19
changed the title
frontend/package-lock.json
Outdated
There was a problem hiding this comment.
Why is there a new package-lock.json?
frontend/src/pages/signin-page.tsx
Outdated
| > | ||
| {showPassword ? ( | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" |
There was a problem hiding this comment.
kindly take this svg out and put it in assets and import like the other svgs being used in the project
frontend/src/pages/signup-page.tsx
Outdated
| > | ||
| {showPassword ? ( | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" |
package-lock.json
Outdated
There was a problem hiding this comment.
Why is there a new package-lock.json?
There was a problem hiding this comment.
give a time I will fix it
|
Kindly rebase the branch to latest branch, worflow file has some changes, so that is causing this fail in PR title checking job |
|
I don't know why it cannot merge.. |
frontend/src/assets/svg/link.svg
Outdated
There was a problem hiding this comment.
Why have you touched this?
frontend/src/pages/signup-page.tsx
Outdated
| </button> | ||
| {errors.fullName && ( | ||
| <p className="p-3 text-xs text-red-500">{errors.fullName.message}</p> |
|
Forget about the PR title check , i'll take care of it. |
|
@GOURAVSINGH19 kindly address the review comments |
|
@GOURAVSINGH19 please change the icons, and don't touch any other icon or update other files, and once all this is done, update the PR description to reflect those icons |
|
Thank you GOURAVSINGH19! Your PR title meets our guidelines. |
|
Closing as there is no positive response on the PR reviews |
Summary
I improve the sign in and signup page by adding visible and hide password feature which help use to check the password before submit...
Recording.2024-05-19.183419.mp4