Propagate ResourceGroup labels and annotations #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I declare a ResourceGroup on disk, I expect the labels and annotations defined on it to be propagated to the in-cluster inventory. That was previously not the case. kioutil annotations are removed (path, index, etc) since they are redundant for inventories that are typically defined in one place, and don't need to be reconstructed by a function pipeline. Signed-off-by: Fredrik Sommar <[email protected]>
fsommar
force-pushed
the
propagate-rg-labels-and-annotations
branch
from
fba2091
to
7264842
Compare
|
Failure is unrelated, due to busybox image being too old. I can change it to the docker hub one, but I assume that you prefer to have it in GCR/GAR? |
Signed-off-by: Fredrik Sommar <[email protected]>
mortent
approved these changes
Jul 1, 2024
|
Thanks for the review @mortent! I don't have permissions to merge, can you do it for me? 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I declare a ResourceGroup on disk, I expect the labels and
annotations defined on it to be propagated to the in-cluster inventory.
That was previously not the case.
kioutil annotations are removed (path, index, etc) since they are
redundant for inventories that are typically defined in one place, and
don't need to be reconstructed by a function pipeline.