Fix broken queue mock.

[ezula]

Summary by CodeRabbit

• Refactor
  • Enhanced job tracking mechanism in queue management system.
  • Improved job execution with asynchronous handling.
  • Updated internal queue processing logic to track remaining jobs more accurately.
• Bug Fixes
  • Addressed issues with the queue mock functionality in the "@zemble/bull" package.

[changeset-bot]

🦋 Changeset detected

Latest commit: 9b71567

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@zemble/bull	Patch
@zemble/ignite	Patch
minimal	Patch
supplement-stack	Patch
todo-app-with-auth-backend	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

The changes involve modifications to the ZembleQueueMock class in the Bull queue implementation. A new private property jobsRemaining is introduced to track the number of jobs in the queue. The add method now increments this property when a job is added, while the #executeWorker method is updated to be asynchronous and decrement jobsRemaining after job execution. The tracking logic in related methods is adjusted to use the new property, improving job state management within the queue.

Changes

File	Change Summary
packages/bull/ZembleQueueMock.ts	- Added private jobsRemaining: number property - Updated #executeWorker method to be async - Modified job tracking logic in add and related methods
.changeset/sixty-seals-give.md	- Patched @zemble/bull package to fix queue mock issues

Possibly related PRs

• Add methods to bull #151: The addition of the getDelayed method in the ZembleQueueMock class is related to the changes in the main PR, as both involve modifications to the ZembleQueueMock class, enhancing its functionality.

Suggested reviewers

• robertherber

Poem

🐰 Queue the jobs, count them tight
Remaining tasks now in clear sight
Async worker, nimble and swift
Tracking jobs with a rabbit's gift
Hop along, queue mechanics bright! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d86c2e8 and 9b71567.

📒 Files selected for processing (1)

• .changeset/sixty-seals-give.md (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• .changeset/sixty-seals-give.md

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: typecheck
• GitHub Check: lint
• GitHub Check: Analyze (javascript-typescript)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkg-pr-new]

Open in Stackblitz

@zemble/auth

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/auth@160

@zemble/auth-anonymous

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/auth-anonymous@160

@zemble/auth-apple

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/auth-apple@160

@zemble/auth-api-token

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/auth-api-token@160

@zemble/auth-otp

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/auth-otp@160

@zemble/bull

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/bull@160

@zemble/bun

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/bun@160

@zemble/core

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/core@160

create-zemble-app

npm i https://pkg.pr.new/kingstinct/zemble/create-zemble-app@160

create-zemble-plugin

npm i https://pkg.pr.new/kingstinct/zemble/create-zemble-plugin@160

@zemble/debug

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/debug@160

@zemble/email-resend

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/email-resend@160

@zemble/email-sendgrid

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/email-sendgrid@160

eslint-config-kingstinct

npm i https://pkg.pr.new/kingstinct/zemble/eslint-config-kingstinct@160

@zemble/firebase-auth

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/firebase-auth@160

@zemble/graphql

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/graphql@160

@zemble/kv

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/kv@160

@zemble/migrations

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/migrations@160

@zemble/mongodb

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/mongodb@160

@zemble/node

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/node@160

@zemble/pino

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/pino@160

@zemble/push-apple

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/push-apple@160

@zemble/push-expo

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/push-expo@160

@zemble/routes

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/routes@160

@zemble/react

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/react@160

@zemble/sms-46elks

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/sms-46elks@160

@zemble/sms-twilio

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/sms-twilio@160

@zemble/supabase

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/supabase@160

@zemble/utils

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/utils@160

commit: 9b71567

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

packages/bull/ZembleQueueMock.ts (3)

28-28: Consider using a private class field for stronger encapsulation.

TypeScript's private modifier only provides compile-time privacy. Consider using the # prefix for runtime privacy guarantees:

-  private jobsRemaining = 0
+  #jobsRemaining = 0

---

97-104: LGTM! Consider using a cleaner decrement syntax.

The async/await changes and the placement in the finally block are correct. However, to maintain consistency with the codebase style:

-      this.jobsRemaining--
+      this.jobsRemaining -= 1

---

114-118: Consider using queueMicrotask for better job scheduling.

A few suggestions to improve this section:

1. Use a cleaner increment syntax
2. Replace setTimeout with queueMicrotask for more predictable timing

-    this.jobsRemaining++
-    setTimeout(async () => {
-      await this.#executeWorker(job)
-    }, 0)
+    this.jobsRemaining += 1
+    queueMicrotask(async () => {
+      await this.#executeWorker(job)
+    })

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4300521 and d86c2e8.

📒 Files selected for processing (1)

• packages/bull/ZembleQueueMock.ts (5 hunks)

🔇 Additional comments (1)

packages/bull/ZembleQueueMock.ts (1)

Line range hint 152-156: LGTM! The promise resolution logic is correct.

The changes to use the new jobsRemaining property are consistent, and the promise resolution logic remains sound.

Also applies to: 162-163

[robertherber]

looks good 👍