[MBL-2063] Delete Legacy RewardsCollectionView #2274
Merged
+5
−2,052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* includes snapshots
scottkicks
requested review from
ifosli,
a team and
jovaniks
and removed request for
a team
ifosli
approved these changes
Feb 6, 2025
scottkicks
merged commit 2642f97
into
scott/delete-legacy-post-campaign-view
4 checks passed
scottkicks
added a commit
that referenced
this pull request
Feb 10, 2025
* remove ViewController and ViewControllerTests * remove ViewModel and ViewModelTests * [MBL-2063] Delete Legacy RewardsCollectionView (#2274) * delete ViewController and ViewControllerTests * includes snapshots * delete ViewModel and ViewModelTests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Also deletes RewardsCollectionViewController, RewardsCollectionViewModel, Tests, and Snapshots
🤔 Why
Now that the "No Shipping" flow has been made the standard, we can start removing the legacy checkout classes.
Doing this class by class for easier reviews and simpler commits.
🛠 How
👀 See
No visible changes
✅ Acceptance criteria
TODO
Removing these classes next: