Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-2063] Delete PostCampaignCheckout Code #2273

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[MBL-2063] Delete PostCampaignCheckout Code #2273

wants to merge 3 commits into from

Conversation

scottkicks
Copy link
Contributor

📲 What

Also deletes PostCampaignViewController, PostCampaignViewModel, Tests, and Snapshots

🤔 Why

Now that the "No Shipping" flow has been made the standard, we can start removing the legacy checkout classes.

Doing this class by class for easier reviews and simpler commits.

🛠 How

  • Deletes PostCampaignViewController, PostCampaignViewControllerTests, and Snapshots
  • Deletes PostCampaignViewModel and PostCampaignViewModelTests
  • Moves any object definitions into NoShipping files where needed.

👀 See

No visible changes

✅ Acceptance criteria

  • Crowdfund and Late Pledge checkout is untouched and functions as expected
  • Tests pass

TODO

Removing these classes next:

  • RewardsCollectionViewController
  • RewardAddOnSelectionViewController
  • RewardsCollectionViewController

@scottkicks scottkicks self-assigned this Feb 4, 2025
@scottkicks scottkicks marked this pull request as ready for review February 4, 2025 21:12
@scottkicks scottkicks requested review from amy-at-kickstarter, a team and stevestreza-ksr and removed request for a team February 4, 2025 21:12
amy-at-kickstarter
amy-at-kickstarter approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Racking up those deletes.

@scottkicks scottkicks requested a review from jovaniks February 5, 2025 19:00
@nativeksr
Copy link
Collaborator

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-at-kickstarter amy-at-kickstarter amy-at-kickstarter approved these changes

@stevestreza-ksr stevestreza-ksr Awaiting requested review from stevestreza-ksr

@jovaniks jovaniks Awaiting requested review from jovaniks

Assignees

@scottkicks scottkicks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottkicks @nativeksr @amy-at-kickstarter