Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix safari clipboard copy issue #482

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

manasmanohar
Copy link
Contributor

What has changed?

This PR includes the following changes:

  • Fixed Safari clipboard issue by disabling Tailwind preflight.
  • Added Tailwind preflight styles manually in custom.css.
  • Fixed icon scaling issues caused by disabling preflight.
  • Reset border-radius for images in table cells and disabled Roboto Bold to prevent font fallback issues.

Please include a summary of the change.

This PR fixes clipboard copy issue on safari and fixes few styling issues.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

How Has This Been Tested?

  • Ran npm run build and npm run serve to verify the changes.
  • Checked clipboard functionality in Safari.
  • Verified proper rendering of images and icons.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.

…, add preflight CSS in custom.css, and fix icon scaling

- Disables Tailwind's preflight to address clipboard functionality issues in Safari.
- Adds custom CSS to compensate for the absence of preflight styles.
- Adds `viewBox` attributes to two SVG icons to prevent them from being cut off after disabling preflight.
- Remove extra margin from default Docusaurus styles on h3, fixing community section heading.

Signed-off-by: manasmanohar <[email protected]>
… Bold to prevent font fallback issues

Signed-off-by: manasmanohar <[email protected]>
@manasmanohar manasmanohar force-pushed the fix-safari-clipboard-copy-issue branch from 5039658 to c859933 Compare December 20, 2024 14:06
@nehagup nehagup merged commit 9419b36 into keploy:main Dec 20, 2024
3 of 6 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
* fix: disable Tailwind preflight to resolve clipboard issues in Safari, add preflight CSS in custom.css, and fix icon scaling

- Disables Tailwind's preflight to address clipboard functionality issues in Safari.
- Adds custom CSS to compensate for the absence of preflight styles.
- Adds `viewBox` attributes to two SVG icons to prevent them from being cut off after disabling preflight.
- Remove extra margin from default Docusaurus styles on h3, fixing community section heading.

Signed-off-by: manasmanohar <[email protected]>

* fix: reset border-radius for images in table cells and disable Roboto Bold to prevent font fallback issues

Signed-off-by: manasmanohar <[email protected]>

---------

Signed-off-by: manasmanohar <[email protected]>
Signed-off-by: Manas Manohar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants