Skip to content

Commit

Permalink
general: python3.9 reached EOL, switch min version
Browse files Browse the repository at this point in the history
also enable 3.13 on CI
  • Loading branch information
karlicoss committed Oct 19, 2024
1 parent a8f86e3 commit 1b3465e
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@ jobs:
strategy:
matrix:
platform: [ubuntu-latest, macos-latest, windows-latest]
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
exclude: [
# windows runners are pretty scarce, so let's only run lowest and highest python version
{platform: windows-latest, python-version: '3.9' },
{platform: windows-latest, python-version: '3.10'},
{platform: windows-latest, python-version: '3.11'},
{platform: windows-latest, python-version: '3.12'},

# same, macos is a bit too slow and ubuntu covers python quirks well
{platform: macos-latest , python-version: '3.9' },
{platform: macos-latest , python-version: '3.10' },
{platform: macos-latest , python-version: '3.11' },
{platform: macos-latest , python-version: '3.12' },
]

runs-on: ${{ matrix.platform }}
Expand Down Expand Up @@ -63,11 +63,13 @@ jobs:
- if: matrix.platform == 'ubuntu-latest' # no need to compute coverage for other platforms
uses: actions/upload-artifact@v4
with:
include-hidden-files: true
name: .coverage.mypy-misc_${{ matrix.platform }}_${{ matrix.python-version }}
path: .coverage.mypy-misc/
- if: matrix.platform == 'ubuntu-latest' # no need to compute coverage for other platforms
uses: actions/upload-artifact@v4
with:
include-hidden-files: true
name: .coverage.mypy-core_${{ matrix.platform }}_${{ matrix.python-version }}
path: .coverage.mypy-core/

Expand All @@ -81,7 +83,7 @@ jobs:

- uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: '3.10'

- uses: actions/checkout@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion my/core/_deprecated/kompress.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def __truediv__(self, key) -> ZipPath:

def iterdir(self) -> Iterator[ZipPath]:
for s in self._as_dir().iterdir():
yield ZipPath(s.root, s.at) # type: ignore[attr-defined]
yield ZipPath(s.root, s.at)

@property
def stem(self) -> str:
Expand Down
2 changes: 1 addition & 1 deletion my/core/pandas.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def _to_jsons(it: Iterable[Res[Any]]) -> Iterable[Json]:
def _as_columns(s: Schema) -> Dict[str, Type]:
# todo would be nice to extract properties; add tests for this as well
if dataclasses.is_dataclass(s):
return {f.name: f.type for f in dataclasses.fields(s)}
return {f.name: f.type for f in dataclasses.fields(s)} # type: ignore[misc] # ugh, why mypy thinks f.type can return str??
# else must be NamedTuple??
# todo assert my.core.common.is_namedtuple?
return getattr(s, '_field_types')
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def main() -> None:
author_email='[email protected]',
description='A Python interface to my life',

python_requires='>=3.8',
python_requires='>=3.9',
install_requires=INSTALL_REQUIRES,
extras_require={
'testing': [
Expand Down

0 comments on commit 1b3465e

Please sign in to comment.