Clone of Nether Labels theme with Nord color palette #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schneegans
requested changes
Feb 8, 2025
There was a problem hiding this comment.
Hi there! Thanks a lot for the contribution!
Did you change anything to the CSS or is it really "only" changing the default colors?
I think it's still ok to merge this in the latter case, but maybe we can think about a "color preset" system so that it's not necessary to duplicate so much code in the future...
Co-authored-by: Simon Schneegans <[email protected]>
|
Yes, it's only changing the default colors. Agreed. It's better if we separated "Menu Theme" and "Color Preset" system so we can use our own colors with different themes. |
Schneegans
approved these changes
Feb 8, 2025
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure it's okay to open PR with cloned menu theme. I like Nether Labels theme and want to use it with Nord color palette so I make changes to it.