Deterministic task chaining - @anthonydevs17: Pause/Resume/Stop features #207

ernestocarrasco · 2025-02-11T12:20:19Z

Add DeterministicExecutionStrategy to handle sequential, task dependencies and parallel workflow processing.
Include Pause/Resume and Stop functionalities

- Added a 'Stop Workflow' button in AgentsBoardDebugger component. - Introduced a stop method in the Team class to halt the workflow and update the state. - Updated ReactChampionAgent to handle the STOPPED status during workflow execution. - Enhanced workflowController to clear the task queue when the workflow is stopped.

… functionalities - Added handlePauseResume and handleStop methods in AgentWithToolPreviewer for managing team workflow states. - Introduced new buttons for pause/resume and stop actions in the UI, with appropriate disabling logic based on workflow status. - Updated Team class to handle stopping workflows more robustly, including abort handling in ReactChampionAgent. - Enhanced error handling for task abortion and logging for better debugging and user feedback. - Introduced AbortError class to manage operation interruptions effectively.

…se-and-resume-agents-workflow

- Adjusted the table formatting in README.md for the tools package to enhance clarity and consistency. - Ensured proper alignment of tool descriptions and documentation links for improved user experience.

…se-and-resume-agents-workflow

…esume, and stop methods - Refactored Team class methods (pause, resume, stop) to utilize new workflow management functions directly from the store, improving code clarity and reducing redundancy. - Updated ReactChampionAgent to track the last feedback message and handle task execution more effectively, including abort handling. - Introduced new error classes (StopAbortError, PauseAbortError) for better error management during workflow interruptions. - Enhanced task logging for aborted tasks, capturing relevant statistics and error details for improved debugging. - Integrated workflow action enums to standardize workflow control actions across the application.

…edbackMessage fields - Added `currentIterations` and `lastFeedbackMessage` fields to various agent instances across multiple test snapshots, enhancing the state tracking of agents during workflows. - Ensured consistency in the agent configurations for improved testing accuracy and reliability. - Updated snapshots for `customLLMs`, `llmProxy`, `outputSchemaTeam`, `productSpecTeam`, `resumeCreationTeam`, `sportNewsTeam`, and `tripPlanningTeam` to reflect these changes.

- Cleaned up the README.md by removing an unnecessary newline before the Compatibility section, improving the overall formatting and readability of the document.

…d refactor task management - Added new ESLint rules to disable focused and disabled tests in Jest. - Updated Jest configuration to specify a test match pattern. - Introduced a new dependency, `dependency-graph`, in package.json and package-lock.json. - Refactored task management in the application by adding a TaskManager for better task lifecycle handling. - Enhanced task and team store functionalities to support new task status updates and flow types. - Removed the workflow controller as part of the task management refactor. Related GH Issue: kaiban-ai#153

…LMEnd method - Eliminated the unnecessary check for PAUSED workflow status in the handleLLMEnd method of ReactChampionAgent, streamlining the task handling process. - This change enhances the agent's responsiveness during task execution by allowing it to proceed without being blocked by the workflow status.

Related issue: kaiban-ai#153

…status management - Introduced a new `handleAgentTaskPaused` method to manage agent status when tasks are paused, improving workflow control during interruptions. - Updated `handleTaskAborted` and `handleTaskPaused` methods to log task status changes and relevant error details, enhancing debugging capabilities. - Refactored task status management to include a new PAUSED state for both agents and tasks, allowing for better tracking of workflow interruptions. - Enhanced error handling in the workflow loop to ensure proper task management during pauses, improving overall system reliability.

- Updated taskSubscriber.js to include the PAUSED state in the subscribeTaskStatusUpdates function, enhancing task status management. - This change aligns with recent enhancements to workflow control, allowing for better tracking of tasks during interruptions.

…orkflow' into 153-tasks-chaining-sequential-hierarchy

- Integrated ChatMessageHistory into agent instances for improved interaction tracking. - Updated agent status management to reset interactions history and feedback upon workflow reset. - Added functionality to start the task queue if paused, ensuring smoother workflow execution. - Removed redundant clearAgentLoopState method from workflow loop store, streamlining state management. - Improved overall task handling and agent responsiveness during workflow interruptions.

…arious workflows - Enhanced snapshot files for `llmProxy`, `outputSchemaTeam`, `productSpecTeam`, `resumeCreationTeam`, `sportNewsTeam`, and `tripPlanningTeam` to include comprehensive `lastFeedbackMessage` fields. - Updated messages to reflect specific tasks and expected outputs, improving clarity and context for each workflow scenario. - Ensured consistency in agent configurations across multiple test snapshots, enhancing the accuracy of state tracking during workflows.

… taskQueue in the store

…/anthonydevs17/KaibanJS into 153-integration-pause-stop

…entLoopState function

…management - Introduced workOnTaskResume method in Agent and BaseAgent classes to handle task resumption. - Implemented workOnTaskResume in ReactChampionAgent to manage task execution with last feedback context. - Updated teamStore to support task resumption in the workflow controller, enhancing task handling during workflow interruptions. - Improved overall agent state management and task queue handling for better responsiveness and control.

…/anthonydevs17/KaibanJS into 153-integration-pause-stop

Related GH Issues: kaiban-ai#153, kaiban-ai#36

- Introduce new execution strategies: DeterministicExecutionStrategy and ManagerLLMStrategy - Add support for parallel task execution with new task management methods - Update Team and Task constructors to support new workflow configuration options - Enhance task status tracking with dedicated executing and pending task sets - Simplify workflow execution strategy selection logic

- Update DeterministicExecutionStrategy to improve task scheduling and parallel execution - Modify teamStore to simplify task status management and remove redundant state updates - Add comprehensive test cases for task execution order, parallel processing, and state transitions - Update jest configuration to focus on specific test files - Improve logging and debugging for workflow execution

- Modify jest configuration to skip certain test cases - Update event planning team test snapshots with new AI-generated content - Adjust logging and debugging settings in test utilities - Remove commented debug logging in moscaFetch utility - Simplify test configurations for trip planning and output schema teams

- Add detailed test cases for pause and resume workflow in event planning and trip planning teams - Update workflow loop store to handle pause, resume, and stop operations more robustly - Modify task store to support pausing and resuming tasks with correct status transitions - Enhance execution strategy to respect workflow status during task scheduling - Remove task queue-related checks and simplify workflow state management

…tion - Introduce optional referenceId parameter in Task constructor - Modify execution strategies to use referenceId for task dependency resolution - Update test files and snapshots to use referenceId instead of id for task references - Refactor dependency tracking in DeterministicExecutionStrategy to use referenceId - Remove deprecated HierarchyExecutionStrategy and SequentialExecutionStrategy files Related GH Issue: kaiban-ai#153

darielnoel · 2025-02-14T22:07:38Z

src/index.js

+    logLevel,
+    inputs = {},
+    env = null,
+    managerWithLLM = false,


Are we using this?

darielnoel · 2025-02-14T22:30:26Z

src/stores/teamStore.js

-              get().updateTaskStatus(tasks[0].id, TASK_STATUS_enum.DOING);
+            // init task queue
+            get().taskQueue = new PQueue({
+              concurrency: strategy.getConcurrencyForTaskQueue(get()),


Why not just having the raw number here? 1. It is hardcoded anyway inside the getConcurrencyForTaskQueue function

darielnoel · 2025-02-14T23:17:44Z

src/stores/teamStore.js

+
+            if (strategy) {
+              strategy
+                .executeFromChangedTasks(


Ummm... This looks a bit complicated to understand.

changedTaskIdsWithPreviousStatus

Is not the name perse, but this way of passing the ids of changed tasks....

darielnoel · 2025-02-14T23:20:57Z

src/workflowExecution/executionStrategies/deterministicExecutionStrategy.js

+    const firstTask = tasks[0];
+
+    // Update task status and execute it
+    teamStoreState.updateStatusOfMultipleTasks(


This seems generic updateStatusOfMultipleTasks.... stores should have specific methods.

darielnoel · 2025-02-14T23:23:09Z

src/workflowExecution/executionStrategies/managerLLMExecutionStrategy.js

+import WorkflowExecutionStrategy from './workflowExecutionStrategy';
+
+class ManagerLLMStrategy extends WorkflowExecutionStrategy {
+  executeFromChangedTasks(_teamStore, _changedTaskIds) {


This method seems a bit complex.... Why not being more direct...

Like this managers just subscribing to the tasks states, and them doing the calculations to work on specific tasks etc?

darielnoel · 2025-02-14T23:25:29Z

src/workflowExecution/workflowController.js

+        return acc;
+      }, []);
+
+      if (changedTaskIdsWithPreviousStatus.length > 0) {


What I will do is habing this subscriptions at the execution manager level... and let each execution to do their thing.

darielnoel · 2025-02-21T04:13:55Z

src/agents/reactChampionAgent.js

+        workflowStatus === WORKFLOW_STATUS_enum.STOPPING
+      ) {
+        return {
+          result: parsedResultWithFinalAnswer,


Why are we passing the parsedResultWithFinalAnswerHere if it is false from the while condition?

darielnoel · 2025-02-21T04:16:41Z

src/index.js

    description,
    expectedOutput,
    agent,
+    dependencies = [],


Make sure to add all this new definitions to the TS types definitions

darielnoel · 2025-02-21T04:20:27Z

src/utils/agents.js

@@ -78,4 +78,36 @@ const getParsedJSON = (str) => {
  }
 };

-export { getApiKey, replaceAgentAttributes, getParsedJSON };
+/**


This is weird... proxy-based clone of a BaseAgent Why?

anthonydevs17 and others added 30 commits January 3, 2025 22:51

feat(workflow): add pause and resume functionality to team workflow

64f815e

remove logs

9662c83

feat(agent): add pause handling to ReactChampionAgent workflow

1ca477c

Merge branch 'main' of https://github.com/kaiban-ai/KaibanJS into pau…

c30a39d

…se-and-resume-agents-workflow

fix(tools): update README formatting for better readability

5ca097f

- Adjusted the table formatting in README.md for the tools package to enhance clarity and consistency. - Ensured proper alignment of tool descriptions and documentation links for improved user experience.

Merge branch 'main' of https://github.com/kaiban-ai/KaibanJS into pau…

ea3f631

…se-and-resume-agents-workflow

docs: remove redundant newline in README.md

d4a7e7f

- Cleaned up the README.md by removing an unnecessary newline before the Compatibility section, improving the overall formatting and readability of the document.

Adjust task handling to follow the 'flux' pattern.

cc7f51b

Related issue: kaiban-ai#153

Merge remote-tracking branch 'anthonydevs17/pause-and-resume-agents-w…

b9cc3ab

…orkflow' into 153-tasks-chaining-sequential-hierarchy

Handle concurrency of the exeuction of tasks by adding all tasks to a…

8bf87f7

… taskQueue in the store

Handle concurrency of the exeuction of tasks by adding all tasks to a…

0be5753

… taskQueue in the store

rerun tests for eventPlanningTeam

d0228c7

remove some files from git

4355b7e

Merge branch 'pause-and-resume-agents-workflow' of https://github.com…

09a971c

…/anthonydevs17/KaibanJS into 153-integration-pause-stop

Adjust execution strategies to fix invalid calling to removed clearAg…

3affc01

…entLoopState function

Remove non-used workflowController

c8a44f1

Remove outdated unit tests for workflow execution

3dae6d1

Merge branch 'pause-and-resume-agents-workflow' of https://github.com…

5326172

…/anthonydevs17/KaibanJS into 153-integration-pause-stop

Remove unused workflowController.js file

1bcb99d

ernestocarrasco added 7 commits January 26, 2025 07:21

153 - Integrate pause/stop/resume features.

3c5ec3b

Add some tests for STOP operation in sequential workflow execution.

da6f605

Related GH Issues: kaiban-ai#153, kaiban-ai#36

Add some tests for STOP process in the hierarchyExecutionStrategy

b34ea78

Related GH Issues: kaiban-ai#153, kaiban-ai#36

This was referenced Feb 11, 2025

Feature: Sequential and hierarchy tasks execution - Included STOP/PAUSE/RESUME features from anthonydevs17 #199

Closed

feat(workflow): add pause and resume functionality to team workflow #180

Open

ernestocarrasco changed the title ~~Deterministic task chaining - Pause/Resume - Stop~~ Deterministic task chaining - @anthonydevs17: Pause/Resume/Stop features Feb 11, 2025

darielnoel reviewed Feb 14, 2025

View reviewed changes

src/index.js Outdated

logLevel,

inputs = {},

env = null,

managerWithLLM = false,

Copy link

Contributor

darielnoel Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using this?

darielnoel reviewed Feb 14, 2025

View reviewed changes

ernestocarrasco added 2 commits February 20, 2025 16:34

Refactor workflow execution strategy and remove LLM manager strategy

a2d69e9

Remove dependency-graph package from project dependencies

8c9cece

darielnoel reviewed Feb 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deterministic task chaining - @anthonydevs17: Pause/Resume/Stop features #207

Deterministic task chaining - @anthonydevs17: Pause/Resume/Stop features #207

ernestocarrasco commented Feb 11, 2025

darielnoel Feb 14, 2025

darielnoel Feb 14, 2025

darielnoel Feb 14, 2025 •

edited

Loading

darielnoel Feb 14, 2025

darielnoel Feb 14, 2025

darielnoel Feb 14, 2025

darielnoel Feb 21, 2025

darielnoel Feb 21, 2025 •

edited

Loading

darielnoel Feb 21, 2025 •

edited

Loading

Deterministic task chaining - @anthonydevs17: Pause/Resume/Stop features #207

Are you sure you want to change the base?

Deterministic task chaining - @anthonydevs17: Pause/Resume/Stop features #207

Conversation

ernestocarrasco commented Feb 11, 2025

darielnoel Feb 14, 2025

Choose a reason for hiding this comment

darielnoel Feb 14, 2025

Choose a reason for hiding this comment

darielnoel Feb 14, 2025 • edited Loading

Choose a reason for hiding this comment

darielnoel Feb 14, 2025

Choose a reason for hiding this comment

darielnoel Feb 14, 2025

Choose a reason for hiding this comment

darielnoel Feb 14, 2025

Choose a reason for hiding this comment

darielnoel Feb 21, 2025

Choose a reason for hiding this comment

darielnoel Feb 21, 2025 • edited Loading

Choose a reason for hiding this comment

darielnoel Feb 21, 2025 • edited Loading

Choose a reason for hiding this comment

darielnoel Feb 14, 2025 •

edited

Loading

darielnoel Feb 21, 2025 •

edited

Loading

darielnoel Feb 21, 2025 •

edited

Loading