feat(router): add payment incoming webhooks support for v2 #6551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperswitch-bot
bot
added
M-database-changes
hyperswitch-bot
bot
removed
M-database-changes
jarnura
requested changes
Nov 13, 2024
| @@ -188,6 +188,33 @@ impl PaymentAttempt { | |||
| .await | |||
| } | |||
|
|
|||
| #[cfg(feature = "v2")] | |||
| pub async fn find_by_merchant_id_connector_txn_id( | |||
There was a problem hiding this comment.
Suggested change
| pub async fn find_by_merchant_id_connector_txn_id( | |
| pub async fn find_by_merchant_id_connector_transaction_id( |
| #[cfg(feature = "v2")] | ||
| pub async fn find_by_merchant_id_connector_txn_id( | ||
| conn: &PgPooledConn, | ||
| merchant_id: &common_utils::id_type::MerchantId, |
| @@ -102,6 +102,16 @@ pub trait PaymentAttemptInterface { | |||
| storage_scheme: storage_enums::MerchantStorageScheme, | |||
| ) -> error_stack::Result<PaymentAttempt, errors::StorageError>; | |||
|
|
|||
| #[cfg(feature = "v2")] | |||
| async fn find_payment_attempt_by_merchant_id_connector_txn_id( | |||
There was a problem hiding this comment.
Suggested change
| async fn find_payment_attempt_by_merchant_id_connector_txn_id( | |
| async fn find_payment_attempt_by_merchant_id_connector_transaction_id( |
| } | ||
| } | ||
|
|
||
| async fn get_payment_id( |
There was a problem hiding this comment.
return objects from the function, just to get a id we shouldn't do database call, if we do so also, return the object so that, the objects can be used later. change the function name too.
There was a problem hiding this comment.
We are not fetching the object in all the cases, in case of PaymentIdType::PaymentIntentId we are directly returning the id
There was a problem hiding this comment.
Can we make this consistent, we should avoid reading same object twice in the flow. Like in redirection, we eliminated double reads
hyperswitch-bot
bot
added
the
M-api-contract-changes
sai-harsha-vardhan
changed the base branch from
main
to
add_finish_redirection
sai-harsha-vardhan
changed the base branch from
add_finish_redirection
to
main
jarnura
requested changes
Nov 14, 2024
| } else if connector.is_webhook_source_verification_mandatory() { | ||
| // if webhook consumption is mandatory for connector, fail webhook | ||
| // so that merchant can retrigger it after updating merchant_secret | ||
| return Err(errors::ApiErrorResponse::WebhookAuthenticationFailed.into()); |
There was a problem hiding this comment.
Avoid return from middle of the flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add payment incoming webhooks support for v2
Additional Changes
Motivation and Context
How did you test it?
Tested Manually
Sanity payment webhooks in v1
Incoming payment webhooks (source_verified = true)
Incoming payment webhooks (source_verified = false)
Checklist
cargo +nightly fmt --allcargo clippy