Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files_handler_params default from FileContentsManager to ContentsManager #1496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaicoTimmerman
Copy link

This PR moves the default files_handler_params from FileContentsManager to ContentsManager to match.

In
https://github.com/jupyter-server/jupyter_server/pull/1069/files#diff-4d8c8c45026f674a455c1e41558c6a9a05d8766adc81a6e56d8cafc7e5d8077cR17 the web.StaticFileHandler was introduced as superclass to FilesHandler. This requires all subclasses of ContentsManager (e.g. a version for S3) to fail serving the file due to:

    Traceback (most recent call last):
      File "/home/bigdata/venv/lib64/python3.11/site-packages/tornado/http1connection.py", line 278, in _read_message
        delegate.finish()
      File "/home/bigdata/venv/lib64/python3.11/site-packages/tornado/httpserver.py", line 399, in finish
        self.delegate.finish()
      File "/home/bigdata/venv/lib64/python3.11/site-packages/tornado/routing.py", line 268, in finish
        self.delegate.finish()
      File "/home/bigdata/venv/lib64/python3.11/site-packages/tornado/web.py", line 2399, in finish
        self.execute()
      File "/home/bigdata/venv/lib64/python3.11/site-packages/tornado/web.py", line 2421, in execute
        self.handler = self.handler_class(
                       ^^^^^^^^^^^^^^^^^^^
      File "/home/bigdata/venv/lib64/python3.11/site-packages/tornado/web.py", line 238, in __init__
        self.initialize(**kwargs)  # type: ignore
        ^^^^^^^^^^^^^^^^^^^^^^^^^
    TypeError: StaticFileHandler.initialize() missing 1 required positional argument: 'path'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant