Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepand PATH expansion instead of append #4213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rec0gnice
Copy link

This improves the evaluation of fzf when there is another version globally installed. So the custom downloaded/installed version takes precendence over the version installed by a packager manager for example.

This improves the evaluation of fzf when there is another version globally installed.
So the custom downloaded/installed version takes precendence over the version
installed by a packager manager for example.
@junegunn
Copy link
Owner

Thanks, but I deliberately made the decision to append in fdaa4e9. The reason is explained in the commit message. If I recall correctly, I made the change after fzf formula landed in Homebrew.

Since e74b125, I don't think the install script matters much. You only need to add a single line to your shell configuration file, and using a package manager like Homebrew is preferable — manual installation via the script makes it easy to miss updates.

Can you tell me more about your set-up? How do you install and update fzf?

@Rec0gnice
Copy link
Author

Thanks for the explanation, didn't know this was a deliberate design decision.
The reason for my PR is that I working with some setups that aren't managed by myself, i.e. I do not have the permissions to use a package manager.
In my latest company-managed system there was fzf already installed via apt on debian, but that was 20 minor versions behind. In this exact circumstance it resulted in the bash autocompletion not being supported.

Feel free to close the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants