-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add login_hint as method to identify end-user in signOut #277
Open
piuma
wants to merge
7
commits into
jumbojett:master
Choose a base branch
from
piuma:login_hint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
79beba8
add login_hint as method to identify end-user in signOut
piuma 1bc3dc7
fix: getState() return empty string
piuma 7cb2f69
fix: getState() return empty string
piuma d2c116e
Fix: setNonce when it's empty
Aladdin-97 7070331
Merge pull request #1 from Aladdin-97/login_hint
piuma 15c2510
resolv conflict
piuma b493b44
fix: http_build_query(): Passing null to parameter #2 ($numeric_prefi…
piuma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happens when the session does not contain the state.
Does this introduce security issues?
It looks to me that it is now possible to reload the page with the
?code=<somecode>&state=<some state>
. Instead that it was normally not possible because the state was unset.Maybe the specs says something about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should for sure not do this - if the session does not hold the necessary values there is something broken.
Same for the nonce below