Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tui-qrcode crate #56

Merged
merged 4 commits into from
Feb 9, 2025
Merged

feat: add tui-qrcode crate #56

merged 4 commits into from
Feb 9, 2025

Conversation

joshka
Copy link
Owner

@joshka joshka commented Jan 23, 2025

This is published to crates.io, but not yet merged due to the Ratatui 0.30 stuff in the main branch.

@joshka joshka requested a review from Copilot January 23, 2025 03:45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

tui-qrcode/README.md:45

  • The method call should be 'style(style)' instead of 'style()'.
let widget = QrCodeWidget::new(qr_code).style();

tui-qrcode/examples/qrcode.rs:23

  • The error message in the expect method is too generic. Consider providing a more descriptive error message.
let qr_code = QrCode::new("https://ratatui.rs").expect("failed to create QR code");
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.

Project coverage is 71.51%. Comparing base (f272002) to head (aedbd16).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tui-qrcode/src/lib.rs 0.00% 57 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   73.18%   71.51%   -1.67%     
==========================================
  Files          14       15       +1     
  Lines        2446     2503      +57     
==========================================
  Hits         1790     1790              
- Misses        656      713      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka joshka merged commit 8e13a8c into main Feb 9, 2025
11 checks passed
@joshka joshka deleted the tui-qrcode branch February 9, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants