Skip to content

Commit

Permalink
chore: various fixes / clippy lints (#6)
Browse files Browse the repository at this point in the history
- **chore: set msrv to 1.74**
- **chore: move shared config to tui-widgets**
- **chore: use workspace package metadata**
- **fix: various clippy lints**
  • Loading branch information
joshka authored Jul 24, 2024
1 parent 2563207 commit 63ec0e3
Show file tree
Hide file tree
Showing 36 changed files with 85 additions and 1,143 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
/target
/Cargo.lock
2 changes: 2 additions & 0 deletions tui-big-text/.markdownlint.yaml → .markdownlint.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
no-inline-html:
allowed_elements:
- h1
- img
- br
- details
- summary
Expand Down
8 changes: 4 additions & 4 deletions tui-big-text/CONTRIBUTING.md → CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# Contribution guidelines

First off, thank you for considering contributing to tui-big-text.
First off, thank you for considering contributing to tui-widgets.

If your contribution is not straightforward, please first discuss the change you
wish to make by creating a new issue before making the change.

## Reporting issues

Before reporting an issue on the
[issue tracker](https://github.com/joshka/tui-big-text/issues),
[issue tracker](https://github.com/joshka/tui-widgets/issues),
please check that it has not already been reported by searching for some related
keywords.

Expand Down Expand Up @@ -55,8 +55,8 @@ A specification for adding human and machine readable meaning to commit messages
This is no different than other Rust projects.

```shell
git clone https://github.com/joshka/tui-big-text
cd tui-big-text
git clone https://github.com/joshka/tui-widgets
cd tui-widgets
cargo test
```

Expand Down
20 changes: 10 additions & 10 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 10 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ authors = ["Joshka"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/joshka/tui-widgets"
edition = "2021"
rust-version = "1.63.0"
rust-version = "1.74.0"
categories = ["command-line-interface", "gui"]
keywords = ["cli", "console", "ratatui", "terminal", "tui"]

Expand All @@ -26,6 +26,15 @@ rstest = "0.21.0"
strum = { version = "0.26.1", features = ["derive"] }
tokio = { version = "1.39" }

[lints.rust]
unused = "warn"

[lints.clippy]
# cargo = "warn" # currently fails because crossterm 0.27.0 uses multiple windows crate versions
pedantic = "warn"
nursery = "warn"


[package]
name = "tui-widgets"
description = "A collection of useful widgets for building terminal user interfaces using Ratatui"
Expand Down
40 changes: 37 additions & 3 deletions bacon.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,15 @@ command = [
need_stdout = false

[jobs.clippy]
command = ["cargo", "clippy", "--all-targets", "--color", "always"]
command = [
"cargo",
"clippy",
"--workspace",
"--all-features",
"--all-targets",
"--color",
"always",
]
need_stdout = false

[jobs.test]
Expand All @@ -48,7 +56,7 @@ need_stdout = false
[jobs.doc-open]
command = ["cargo", "doc", "--color", "always", "--no-deps", "--open"]
need_stdout = false
on_success = "back" # so that we don't open the browser at each change
on_success = "job:doc" # so that we don't open the browser at each change

# You can run your application and have the result displayed in bacon,
# *if* it makes sense for this crate. You can run an example the same
Expand All @@ -65,9 +73,35 @@ command = [
need_stdout = true
allow_warnings = true

[jobs.coverage]
command = [
"cargo",
"llvm-cov",
"--workspace",
"--lcov",
"--output-path",
"target/lcov.info",
"--color",
"always",
]

[jobs.format]
command = ["cargo", "+nightly", "fmt", "--", "--check"]

[jobs.rdme]
command = ["cargo", "rdme", "--force"]
need_stdout = true

[jobs.vhs]
command = ["vhs", "tui-prompts/examples/text.tape"]
need_stdout = true

# You may define here keybindings that would be specific to
# a project, for example a shortcut to launch a specific job.
# Shortcuts to internal functions (scrolling, toggling, etc.)
# should go in your personal global prefs.toml file instead.
[keybindings]
# alt-m = "job:my-job"
shift-r = "job:rdme"
f = "job:format"
o = "job:coverage"
v = "job:vhs"
File renamed without changes.
File renamed without changes.
File renamed without changes.
15 changes: 0 additions & 15 deletions tui-big-text/.github/dependabot.yml

This file was deleted.

12 changes: 0 additions & 12 deletions tui-big-text/.github/workflows/check.yml

This file was deleted.

17 changes: 0 additions & 17 deletions tui-big-text/.github/workflows/release.yml

This file was deleted.

11 changes: 0 additions & 11 deletions tui-big-text/.github/workflows/test.yml

This file was deleted.

2 changes: 0 additions & 2 deletions tui-big-text/.gitignore

This file was deleted.

Loading

0 comments on commit 63ec0e3

Please sign in to comment.