Fix: Scroll offset in Title Select Popup was off (#25)

jooaf · Jan 24, 2025 · 1ebec63 · 1ebec63
1 parent c02f981
commit 1ebec63
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/title_select_popup.rs b/src/title_select_popup.rs
@@ -74,7 +74,7 @@ impl TitleSelectPopup {
             self.selected_index = self.filtered_titles.len() - 1;
         }
 
-        if self.selected_index < self.scroll_offset {
+        if self.selected_index <= self.scroll_offset {
             self.scroll_offset = self.selected_index;
         }
         if self.selected_index == self.filtered_titles.len() - 1 {

diff --git a/src/ui_handler.rs b/src/ui_handler.rs
@@ -1,4 +1,4 @@
-use crate::{get_save_backup_file_path, EditorClipboard, BORDER_PADDING_SIZE};
+use crate::{get_save_backup_file_path, EditorClipboard};
 use anyhow::{bail, Result};
 use crossterm::{
     event::{self, DisableMouseCapture, EnableMouseCapture, KeyCode, KeyModifiers},
@@ -243,8 +243,8 @@ fn handle_title_select_popup_input(state: &mut UIState, key: event::KeyEvent) ->
     // The borders are rendered using unicode box-drawing characters:
     // top border    : ┌───┐
     // bottom border : └───┘
-    let visible_items = (state.scrollable_textarea.viewport_height as f32 * 0.8).floor() as usize
-        - BORDER_PADDING_SIZE;
+    let visible_items =
+        (state.scrollable_textarea.viewport_height as f32 * 0.8).floor() as usize - 10;
 
     match key.code {
         KeyCode::Enter => {