Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Speed up function get_stack_sampler by 28% #364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pyinstrument/stack_sampler.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,13 @@ def get_stack_sampler() -> StackSampler:
"""
Gets the stack sampler for the current thread, creating it if necessary
"""
if not hasattr(thread_locals, "stack_sampler"):
thread_locals.stack_sampler = StackSampler()
return thread_locals.stack_sampler
try:
return thread_locals.stack_sampler
except AttributeError:
# Attribute 'stack_sampler' doesn't exist in thread_locals, create it
stack_sampler = StackSampler()
thread_locals.stack_sampler = stack_sampler
return stack_sampler


def build_call_stack(frame: types.FrameType | None, event: str, arg: Any) -> list[str]:
Expand Down