Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong link in iframe.md #556

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

korrectional
Copy link

@korrectional korrectional commented Jan 28, 2025

@damencho
Copy link
Member

The link is relative to the current path and is working as expected in the handbook

@korrectional
Copy link
Author

korrectional commented Jan 29, 2025

The link is relative to the current path and is working as expected in the handbook

When I am directed to https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-iframe/dev-guide-react-sdk I see this: https://imgur.com/a/v8jRl1V
I tested this on both my phone and pc.

@damencho
Copy link
Member

Hum, am I doing it wrong? I go to this page
Screenshot_20250129-083123
And when I click the link for the tip about React SDK I'm forwarded to this page:
Screenshot_20250129-083130

@saghul
Copy link
Member

saghul commented Jan 29, 2025

FWIW I get the same behavior as OP, aka page not found.

That said, the proposed fix is not good, it should be the document ID and docusaurus generates de right link. Unless there is a bug lurking somewhere...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants