Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUDIT: 37314 #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AUDIT: 37314 #191

wants to merge 1 commit into from

Conversation

coachchucksol
Copy link
Contributor

  • If the staker withdrawing is either the program fee wallet or vault fee wallet, don't take their respective fees

Entry:
37314 (High) "Vault creators can not withdraw their fees without being recursively charged (vault and program) fees on their own fees which causes permanent loss of funds"

The program fee is still assessed on withdrawals of VRT from the program fee wallet, so some amount will always remain in the program fee wallet for as long as the vault is operational. I do not agree with the severity. I think this makes more sense as a Medium finding.

@coachchucksol coachchucksol changed the title AUDIT: 36903 AUDIT: 37314 Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.85%. Comparing base (c736bca) to head (296b177).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   80.70%   80.85%   +0.15%     
==========================================
  Files          91       91              
  Lines        9944    10024      +80     
==========================================
+ Hits         8025     8105      +80     
  Misses       1919     1919              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ebatsell ebatsell mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants