Update Jenkinsfile to follow archetypes #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't look like https://github.com/jenkinsci/bitbucket-kubernetes-credentials-plugin/pull/172/files Can you use the archetype one ? We can safely remove old java version |
jonesbusy
requested changes
Feb 12, 2024
There was a problem hiding this comment.
Use archetype file from https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile
jonesbusy
requested changes
Feb 12, 2024
Jenkinsfile
Outdated
| useContainerAgent: true, // Set to `false` if you need to use Docker for containerized tests | ||
| configurations: [ | ||
| [platform: 'linux', jdk: 11], | ||
| [platform: 'linux', jdk: 17], | ||
| [platform: 'linux', jdk: 21], | ||
| [platform: 'windows', jdk: 17], |
There was a problem hiding this comment.
Windows doesn't make any sense here. It's a plugin that will work only on Kubernetes linux nodes
|
have updated to follow archetype and removed the windows jdk |
jonesbusy
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done
Haven't older jdks 11 and 17.
Submitter checklist