-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Migration 0004 into two migrations #1196
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1196 +/- ##
==========================================
- Coverage 97.56% 97.54% -0.02%
==========================================
Files 32 32
Lines 2132 2120 -12
==========================================
- Hits 2080 2068 -12
Misses 52 52 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Citus postgres isn't technically a supported database. That said I don't see a reason not to do our best to support it.
However we need to document why we're doing this here. Please add comment explaining why, with links to Citus DB documentation that demonstrates what is not supported and the specific error that you get from Citus if this is not done in 2 steps.
Citus Postgres DB doesnt allow adding of new field with constrains on it. Example Error attached You can issue each command separately such as ALTER TABLE oauth2_provider_accesstoken ADD COLUMN id_token data_type; ALTER TABLE oauth2_provider_accesstoken ADD CONSTRAINT constraint_name CHECK (check_expression);
@abu-siddique-shipsy will you be doing this?
|
@abu-siddique-shipsy Have you opened an issue against Citus that shows this error that makes it non-compliant with Django Postgres support? It seems like that's where the appropriate compatibility fix should live given that DOT is not the only place where migrations like 0004 happen. Also you say "Example Error attached" above but I don't see the attachment. |
closing as stale. Feel free to reopen with the requested changes. |
Citus Postgres DB doesnt allow adding of new field with constrains on it. Example Error attached
You can issue each command separately such as ALTER TABLE oauth2_provider_accesstoken ADD COLUMN id_token data_type; ALTER TABLE oauth2_provider_accesstoken ADD CONSTRAINT constraint_name CHECK (check_expression);
Fixes #
Description of the Change
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS