-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH - Add logo and favicon to docs #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Tania. Looks good to me. :)
What's the purpose of moving all the files here? This is going to cause conflicts with every other in-flight PR, so I'd lean toward not merging this change. Can we add the logo and favicon without modifying the file structure of the repo? |
I actually branched off #65 Which added the logo, styling, the landing page and changes the docs structure - I am unsure why that change was made there, but I assumed that had been discussed when opening #65. We can add the logo and favicon without changing the structure of the repo but we'd need to then revert the changes in #65 for this purpose. |
Ah, got it. In that case we need to wait for #65 to be merged, at which point we can rebase this and the diff should be small. |
OK, the style update is merged. Can you rebase this? Thanks! |
3262bb2
to
6dcf33f
Compare
@jakevdp this is ready to merge. Also while building locally I noticed the Note on the tutorials index so I changed to an admonition to make it more noticeable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR:
_static
directory so that this can be rendered by Sphinx book🔗 Link to PR preview: https://jax-ai-stack--114.org.readthedocs.build/en/114/