Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove delegation whitelist #62

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Oct 21, 2024

After discussion w/ @onbjerg – this PR removes the delegation whitelist check – allowing consumers to use their own delegation contracts. Existing checks on gas limits to avoid abuse should be sufficient for now.

@jenpaff
Copy link

jenpaff commented Oct 22, 2024

@jxom e2e tests where fixed, should work now if you update the branch

@onbjerg
Copy link
Member

onbjerg commented Oct 22, 2024

Need to think about this a bit more, but implementation wise it looks fine to me

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs a rebase

@onbjerg onbjerg merged commit 3269b6a into ithacaxyz:main Oct 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants