Improve Google Drive auth failure error reporting #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhora
force-pushed
the
gdrive-tests
branch
from
7009552 to
1f4e3eb
Compare
efiop
reviewed
Dec 21, 2019
efiop
reviewed
Dec 21, 2019
efiop
reviewed
Dec 21, 2019
shcheklein
reviewed
Dec 21, 2019
shcheklein
reviewed
Dec 21, 2019
shcheklein
reviewed
Dec 22, 2019
efiop
reviewed
Dec 22, 2019
efiop
reviewed
Dec 22, 2019
efiop
reviewed
Dec 22, 2019
efiop
reviewed
Dec 22, 2019
maxhora
force-pushed
the
gdrive-tests
branch
from
d5950a9 to
dcdcceb
Compare
efiop
reviewed
Dec 24, 2019
efiop
reviewed
Dec 24, 2019
efiop
reviewed
Dec 24, 2019
maxhora
force-pushed
the
gdrive-tests
branch
from
dcdcceb to
2ad174a
Compare
efiop
reviewed
Dec 25, 2019
efiop
approved these changes
Dec 25, 2019
shcheklein
reviewed
Dec 25, 2019
shcheklein
reviewed
Dec 25, 2019
maxhora
force-pushed
the
gdrive-tests
branch
2 times, most recently
from
72a2f57 to
4a721af
Compare
maxhora
force-pushed
the
gdrive-tests
branch
from
4a721af to
4727cb7
Compare
shcheklein
approved these changes
Dec 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2865
Addresses issue "Processing of auth exceptions and printing more meaningful error message on failure. #2551 (comment)"
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏