Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use lodable to avoid media player ssr #1529

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

astagi
Copy link
Member

@astagi astagi commented Feb 6, 2025

Fixes #1506

@astagi astagi force-pushed the fix/1506_ssr_mediaplayer branch from 2ec37b2 to f512681 Compare February 6, 2025 22:32
Copy link
Contributor

github-actions bot commented Feb 6, 2025

⚠️ @astagi your PR decreased Lighthouse scores! ⚠️

  • ⚠️ /design-system/ best-practices down to 92
  • ⚠️ /design-system/componenti/accordion/ best-practices down to 92
  • ⚠️ /design-system/fondamenti/colori/ best-practices down to 92
  • ⚠️ /community/ best-practices down to 92
  • ⚠️ /community/media/ best-practices down to 92
  • ⚠️ /community/media/20241217-community-lab/ best-practices down to 92
  • ⚠️ /progetto/piano-attivita/ best-practices down to 92

⚡ Lighthouse report for the home page 🏠

Category Score
🟠 Performance 51
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

See the full report...

Other pages

@astagi
Copy link
Member Author

astagi commented Feb 6, 2025

@Fupete it seems to work 🧐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review our media-player (and overlay)
2 participants