Expand testing #61
Closed
Expand testing #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generation as well as removing unused arguments.
- Remove Required/Optional in deserialization - re-introduce a basic_opt type to be more explicit about presense of default values
…eserialization strategies to extend testing
|
Copilot generate summary, which is actually not too bad :-) I'd add that the PR refactors deserialization and extends testing to test both fast and full deserialization though use of the test lib, by doing dependency injection. Benchmarks are also updated to test serialization and deserialization of empty messages and some other tuning |
andersfugmann
force-pushed
the
andersfugmann/extend_tests
branch
from
7f761cd to
8bf45c1
Compare
|
Closing as developement has moved to https://github.com/andersfugmann/ocaml-protoc-plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a series of changes primarily focused on improving the benchmarking process and modifying the deserialization process in the OCaml Protoc Plugin. The main changes include adding a new test function for integer tests, increasing the benchmark quota, adding a new
empty.protofile, and making significant changes to thedeserialize.mlanddeserialize.mlifiles.Benchmarking improvements:
Makefile: Modified thebenchcommand to include a--profile=benchoption, enhancing the benchmarking process.bench/bench.ml: Added a new functionmake_int_testsfor integer tests and increased the benchmark quota from 1.0 to 5.0 seconds. Also, added amake_testscall for theProtoc.Emptymodule. [1] [2] [3]Additions to the codebase:
bench/empty.proto: Added a newempty.protofile.bench/plugin/duneandbench/protoc/dune: Modified to includeempty.mlin the targets and../empty.protoin the dependencies. [1] [2]dune-workspace: Added newocamlopt_flagsfor thebenchenvironment.Changes to the deserialization process:
src/ocaml_protoc_plugin/deserialize.mlandsrc/ocaml_protoc_plugin/deserialize.mli: Made significant changes to the deserialization process, including modifying thevaluefunction, adding new functions likeextension_ranges,deserialize_fast, anddeserialize_full, and modifying thedeserializefunction. These changes aim to improve the efficiency and flexibility of the deserialization process. [1] [2] [3] [4] [5] [6] [7]