Improve handling of extensions. #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersfugmann
force-pushed
the
andersfugmann/extensions_handling
branch
from
736a7b3 to
7c98d9b
Compare
andersfugmann
changed the title
andersfugmann
force-pushed
the
andersfugmann/extensions_handling
branch
2 times, most recently
from
770bc35 to
1a0f2a1
Compare
…generation as well as removing unused arguments.
andersfugmann
force-pushed
the
andersfugmann/extensions_handling
branch
from
1a0f2a1 to
e03895f
Compare
|
Based after merging #55 |
|
Closing as developement has moved to https://github.com/andersfugmann/ocaml-protoc-plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve handling of extensions.
This generalizes extension handling by adding extensions to the serialization and deserialization spec. This allows cleaner less explicit handling of extensions and some optimization where empty lists does not need to be passed to the constructor.
This PR is based on #55. I recommend reviewing after #55 has been merged, or to only review the last five commits.