Do not trigger backend auto-resolution #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
May 30, 2023
| @@ -208,9 +208,9 @@ def configure_inline_support(shell, backend): | |||
|
|
|||
| def _enable_matplotlib_integration(): | |||
| """Enable extra IPython matplotlib integration when we are loaded as the matplotlib backend.""" | |||
| from matplotlib import get_backend | |||
| from matplotlib import _get_backend_or_none | |||
There was a problem hiding this comment.
The problem I see with this approach is that you're using a private function for it. So, if Matplotlib API changes in the future, this would break.
Pinging @tacaswell about it to see what he thinks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
matplotlibwill selected a backend if none is already selected when callingget_backend. It should not be used if you just want to know what the backend is.See #25.