feat(toggle): add iOS 18 haptic feedback #29945
Open
+59
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jedlikowski
commented
Oct 17, 2024
| @@ -312,7 +343,8 @@ export class Toggle implements ComponentInterface { | |||
| [`toggle-${rtl}`]: true, | |||
| })} | |||
| > | |||
| <label class="toggle-wrapper"> | |||
| {this.renderFallbackHapticElements()} | |||
| <label class="toggle-wrapper" onClick={this.onClick}> | |||
There was a problem hiding this comment.
onClick listener moved to label, without this change Host was capturing clicks on the haptic <label> too, not only on .toggle-wrapper
jedlikowski
commented
Oct 17, 2024
| const { inputId } = this; | ||
| const mode = getIonMode(this); | ||
|
|
||
| if (hapticAvailable() || mode !== 'ios') { |
There was a problem hiding this comment.
If I understand correctly, we don't need these elements if Vibration API is available, because then hapticSelection() will work.
OS-pedrolourenco
requested review from
thetaPC
and removed request for
OS-pedrolourenco
|
Hi @thetaPC, could you take a look? Do you have any suggestions? Or can we get this merged? Can't wait to have haptic feedback on toggles in my PWA 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29942
What is the current behavior?
Safari on iOS doesn't support vibration API and it might never do: WebKit/standards-positions#267. However, as described in the issue, since iOS 18 we can use a special
<input type=checkbox switch>element to bring haptic feedback to PWAs by triggering a click on this input's label.What is the new behavior?
<label>with<input type=checkbox switch>insideDoes this introduce a breaking change?
Other information
No visual changes, just slight haptic feedback when changing Toggle state on iOS 18+