-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add binary support #144
base: master
Are you sure you want to change the base?
add binary support #144
Conversation
Signed-off-by: wwqgtxx <[email protected]>
Signed-off-by: wwqgtxx <[email protected]>
Signed-off-by: wwqgtxx <[email protected]>
Signed-off-by: wwqgtxx <[email protected]>
Signed-off-by: wwqgtxx <[email protected]>
@wwqgtxx i hope this PR will be merged soon but its better if you can edit the If i have image from camera and i want to emit, what should i do? transform it to byte and send? |
It would be great to get this merged and the fix in issue #126 |
@khanhvu161188 It's only need to send data with the python's Notice: This patch can't let the binary data send on the |
@wwqgtxx Since @invisibleroads didn't merge our MR, can u give me some tips for cloning your project, compiling it and use instead of version that I install via |
@khanhvu161188 you can try to use
|
@wwqgtxx tks so much. Notice: This patch can't let the binary data send on the XHR protocol now, please check the connect protocol is |
@wwqgtxx I'm trying to use openCV for reading frame and then try to send via socket.io http://docs.opencv.org/2.4/modules/highgui/doc/reading_and_writing_images_and_video.html
So can i use this result for sending via socket.io ? Its Also when i receive from client, can you give me some detail for transform this |
the simple way to confirm you send a sio.send(bytearray(your_data)) If this code not cause error, it well send the binary data to server successfully. |
@wwqgtxx I can see data come to server and other client can receive it. |
@wwqgtxx i got the answer. For getting image from
Hope its helpful for another |
@wwqgtxx I might be able to get to it before if I can find three solid days to focus on socket.io stuff. |
@invisibleroads is there any update on the progress of merging the binary support in by march 1st? It would be awesome to be able to go back to this main repo and not be porting fixes to feus' version too from here! If there's anything I can do to help you let me know :) |
@invisibleroads Hi ! Same here binary support would be awesome ! Thanks for all your work ! And thanks @wwqgtxx for your PR. |
Would be great to have this available. Trying this PR and the other fork I see some issues when sending bytes data on websockets that are also transmitting strings (JSON) with separate frames getting jumbled together. edit: Scratch that, I was communicating with a py27 server. Everything works great. |
to fix issue #130