Suffix ISFS folder name with web app path #1484
Conversation
| @@ -146,7 +146,7 @@ export async function addServerNamespaceToWorkspace(resource?: vscode.Uri): Prom | |||
| const params = new URLSearchParams(uri.query); | |||
| const project = params.get("project"); | |||
| const csp = params.has("csp"); | |||
| const name = `${project ? `${project} - ` : ""}${serverName}:${namespace}${csp ? " web files" : ""}${ | |||
| const name = `${project ? `${project} - ` : ""}${serverName}:${namespace}${!csp ? "" : ["", "/"].includes(uri.path) ? " web files" : ` web files (${uri.path})`}${ | |||
There was a problem hiding this comment.
Can we make the names shorter? How about server:NS (Web) and server (app/path)? We should change the project one to server:NS (project) as well to match.
There was a problem hiding this comment.
Like this?
Seems OK as long as I don't have a project named "Web"
There was a problem hiding this comment.
I like that better, but I think we can remove the namespace when we're tied to a specific web app. IMO that extra info isn't worth the space in that case. I see what you mean with the potential web and project conflict. Do you want to leave the "web files" suffix then? I doubt that conflict will come up in reality but it could be confusing for a user if it does.
There was a problem hiding this comment.
How about this?
There was a problem hiding this comment.
I'm having second thoughts about the change we've made to how a project folder gets named. Some people might not like how the project name is demoted. Here's the old way:
There was a problem hiding this comment.
Oh, I forgot that the project used to come first! I agree, let's put that back.
This PR fixes #1483
Before the change the result was: