Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[_]: feature/Restore stripe checkout for mobile app #1461

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[_]: feature/Restore stripe checkout for mobile app #1461

wants to merge 5 commits into from
+48 −9

Conversation

CandelR
Copy link
Contributor

@CandelR CandelR commented Feb 12, 2025 •
edited
Loading

Description

  • Restored old checkout to make it work in mobile apps

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

How Has This Been Tested?

  • Open mobile drive app and navigated to manage subscription view, try to buy a new one and the payment stripe has to be open

Additional Notes

  • To test it in staging we have to generate custom app pointing to staging

@CandelR CandelR added bug Something isn't working enhancement New feature or request labels Feb 12, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 9:03am

@CandelR CandelR changed the title feat: get the checkout sessionId and redirect to Stripe [_]: feature/Restore stripe checkout for mobile app Feb 12, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 12, 2025 •
edited
Loading

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b4b2a5
Status:⚡️  Build in progress...

View logs

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@CandelR CandelR marked this pull request as draft February 12, 2025 15:45
@CandelR CandelR marked this pull request as ready for review February 13, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jona-Internxt Jona-Internxt Jona-Internxt approved these changes

@xabg2 xabg2 Awaiting requested review from xabg2

Assignees

@CandelR CandelR

@xabg2 xabg2

Labels
bug Something isn't working enhancement New feature or request ready-for-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CandelR @Jona-Internxt @xabg2