Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PB-3774]: feat/auth for vpn extension #1453

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

xabg2
Copy link
Contributor

@xabg2 xabg2 commented Feb 4, 2025

Description

New implementation to obtain the new token when the user authenticates from VPN to use premium features.

We use window.postMessage to send the token to the extension, where the extension can get it via a web worker.

Related Pull Requests

VPN PR

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

How Has This Been Tested?

  • Open Chrome browser
  • Enable Developer Mode
  • Add the extension build folder (ask me by DM for it - this folder points to staging, so if you want to test it, we should deploy this branch in Staging. If not, we can merge this PR in production and I can package the extension as if it were for production to point to drive.internxt.com).
  • Open the extension.
  • Test the authentication (we jus get the user token).

@xabg2 xabg2 added the enhancement New feature or request label Feb 4, 2025
@xabg2 xabg2 self-assigned this Feb 4, 2025
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 0:22am

Copy link

cloudflare-workers-and-pages bot commented Feb 5, 2025

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: d819cf5
Status:⚡️  Build in progress...

View logs

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant