Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to hybrid enc in InviteDialogContainer #1422

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Switch to hybrid enc in InviteDialogContainer #1422

wants to merge 13 commits into from
+257 −5

Conversation

TamaraFinogina
Copy link
Contributor

@TamaraFinogina TamaraFinogina commented Jan 14, 2025 •
edited
Loading

Description

Switch encryption to a hybrid version with Kyber and ensure that it works as expected

Related Issues

Relates to PB-2666

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

How Has This Been Tested?

Unit tests:

  1. The new hybrid function works as expected with Kyber key
  2. The new hybrid function works as before without Kyber key

Additional Notes

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 11:35am

@TamaraFinogina TamaraFinogina marked this pull request as draft January 14, 2025 17:14
@TamaraFinogina TamaraFinogina mentioned this pull request Jan 14, 2025
Draft
7 tasks
@TamaraFinogina TamaraFinogina force-pushed the feat/switch_to_kyber_enc branch from 1acdebf to 1f68c18 Compare January 14, 2025 17:25
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 14, 2025 •
edited
Loading

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 40e71c9
Status:⚡️  Build in progress...

View logs

@TamaraFinogina TamaraFinogina self-assigned this Jan 14, 2025
Base automatically changed from feature/PB-2666-implement-pqc to master January 23, 2025 10:23
@TamaraFinogina TamaraFinogina marked this pull request as ready for review January 24, 2025 10:15
@TamaraFinogina TamaraFinogina requested a review from sg-gs January 24, 2025 10:15
@TamaraFinogina TamaraFinogina changed the title Switch to hybrid enc in InviteDialogContainer and index Switch to hybrid enc in InviteDialogContainer Jan 29, 2025
@TamaraFinogina TamaraFinogina marked this pull request as draft January 29, 2025 11:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CandelR CandelR Awaiting requested review from CandelR CandelR is a code owner

@sg-gs sg-gs Awaiting requested review from sg-gs

At least 1 approving review is required to merge this pull request.

Assignees

@TamaraFinogina TamaraFinogina

Labels
ready-for-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TamaraFinogina @TomaF