-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[_] feat: add hybrid encryption support for pre created users #465
base: master
Are you sure you want to change the base?
Conversation
bd12b20
to
be04718
Compare
be04718
to
a70fe50
Compare
c10f374
to
9933af0
Compare
9933af0
to
f80954b
Compare
f80954b
to
d7aaf94
Compare
d7aaf94
to
282ca7e
Compare
282ca7e
to
d5a2c97
Compare
d5a2c97
to
065bab4
Compare
065bab4
to
8f34ca9
Compare
8f34ca9
to
23d5d48
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the cryptography tests a bit weak. The main reason is that we are mocking the underlying libraries doing the hard thing, which is not the best way to ensure this does not get broken.
It would be better to use NIST cases hardcoded here so we assert the same things that some of the best cryptography experts in the world consider valid to ensure the validity of algorithms like Kyber.
Therefore, I invite @TamaraFinogina here to join the review as she has done that on drive-web
We need to add support for pre-created users' Kyber keys. This PR enables the backend to generate temporary Kyber keys while also allowing hybrid-encrypted invitations to be updated with frontend-generated keys when the user registers.
Changes
Updated Endpoints
POST /users/
: Now updates hybrid-encrypted invitations when a pre-created user registers.POST /users/pre-created/register
: Now updates hybrid-encrypted invitations when a pre-created user registers.POST /users/pre-created/
: Now generates Kyber keys alongside ECC keys.