Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[_]: feat/automate-pr-precondition-checks #193

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

sg-gs
Copy link
Member

@sg-gs sg-gs commented Aug 9, 2023

No description provided.

@sg-gs sg-gs changed the title [_]: feat/add-dangerfile [_]: feat/automate-pr-precondition-checks Aug 9, 2023
@sg-gs sg-gs temporarily deployed to development August 9, 2023 16:03 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Fails
🚫

Danger failed to run dangerfile.ts.

Warnings
⚠️ Please include a description of your PR changes.

Error TypeError

Cannot read property 'split' of null
TypeError: Cannot read property 'split' of null
    at provideAGoodDescription (dangerfile.ts:14:44)
    at fns.forEach (dangerfile.ts:1:52)
    at Array.forEach (<anonymous>)
    at onAPrWeWantTo (dangerfile.ts:1:36)
    at Object.<anonymous> (dangerfile.ts:42:1)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.requireFromString [as default] (/usr/src/danger/node_modules/require-from-string/index.js:28:4)
    at Object.<anonymous> (/usr/src/danger/distribution/runner/runners/inline.js:144:63)
    at step (/usr/src/danger/distribution/runner/runners/inline.js:32:23)
    at Object.next (/usr/src/danger/distribution/runner/runners/inline.js:13:53)

Dangerfile

 9|   if (!includesDescription) {
10|     warn('Please include a description of your PR changes.');
11|   }
12| 
13|   const mandatorySections = [
----------------------------------------------^
14|     'What does this PR do?',
15|     'Why are we doing this?',
16|     'How are we doing this?',
17|     'Should this be manually tested & how?',

Generated by 🚫 dangerJS against b5b3570

@sg-gs sg-gs temporarily deployed to development August 9, 2023 16:05 — with GitHub Actions Inactive
@sg-gs sg-gs temporarily deployed to development August 9, 2023 16:08 — with GitHub Actions Inactive
@sg-gs sg-gs temporarily deployed to development August 9, 2023 16:13 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sg-gs sg-gs self-assigned this Aug 10, 2023
@sg-gs sg-gs added the stalled label Apr 11, 2024
@sg-gs sg-gs requested a review from apsantiso as a code owner May 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant