Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Horizon] Update from master #3092

Merged
merged 95 commits into from
Jan 31, 2025

Conversation

Ahmed-Naguib93
Copy link
Contributor

Remove duplicate files in unit test files

inst-danger and others added 30 commits October 15, 2024 13:33
[ignore-commit-lint]
…e screen (#2920)

refs:MBL-17951
affects: Student, Parent
release note: none

test plan:
refs: MBL-17939
affects: Teacher
release note: Fixed LTI content embedded in RCE submissions not displaying in SpeedGrader.

test plan: See ticket
…elector screen not reacting to cancel when in error or loading states. (#2926)

refs: MBL-17877
affects: Student
release note: Fixed cancel not working on offline sync picker screen while the screen is loading or displaying an error. Fixed offline sync picker failing to load in some cases.

test plan: See ticket.
[ignore-commit-lint]
refs: MBL-17936
affects: Student, Teacher
release note: Fixed an issue that prevented sending messages to more than 100 people.

test plan:
refs: MBL-17893
affects: Parent
release note: Fixed alert list not refreshing after an alert is read or dismissed.
… the cursor to the end. (#2927)

refs: MBL-17838
affects: Student, Teacher
release note: Fixed issues after pasting long text in inbox messages.
refs: MBL-17976
affects: Student, Teacher, Parent
release note: none
refs: MBL-17890
affects: Student, Teacher, Parent
release note: none

test plan:
refs: MBL-17959
affects: Teacher, Student
release note: Inbox messages now show attached audio/video comments.

test plan:
refs: MBL-17944
affects: Student, Parent
release note: Fixed some assignments being visible on the grades screen when the shouldn't be.

test plan:
refs: MBL-18022
affects: none
release note: none

test plan: Tests to pass
refs: MBL-17936
affects: Teacher, Student
release note: none

test plan:
refs: MBL-17971
affects: Student, Teacher
release note: Custom calendar frequency screen now reuses the currently selected frequency.

test plan: See PR description
refs: MBL-17864
affects: Student, Teacher, Parent
release note: none

test plan:
- Log in to the beta environment.
- Link course files to where rich content is enabled using a web browser. (Assignment, quiz, discussion, announcement, page, syllabus, calendar event)
- Check the linked files is they are still working from the apps.
[ignore-commit-lint]
…2955)

* Fix inbox tab badge value

* Update count on main queue

refs: MBL-18045
affects: Student,Teacher
release note: Fix the issue of missing Indicator of unread messages on Inbox icon

test plan: See PR description

* Fix unit tests

* Update InboxMessageInteractorLiveTests.swift

* Update FileSubmissionItemsUploadStarterTests.swift
…e mode (#2957)

refs: MBL-17988
affects: Student,Teacher
release note: Fix the issue of annotation bar move button being cut off on landscape mode.

test plan: See PR description
refs: MBL-17910
affects: Student, Teacher, Parent
release note: none

test plan: See PR description
* refs: MBL-18034
affects: Student
release note: none

Implement Offline Assignments E2E test case.
Add new helper (OfflineHelper) for Offline mode dialog (and future usage).

* Minor refactor.

* Update .gitignore

* Refactor according to PR comments.

* Remove Package.resolved from gitignore

* Delete screenlog.0

* Delete Brewfile.lock.json

* Remove trailing whitespaces in whitespace-only lines.

* Remove trailing whitespace from DashboardHelper
refs: MBL-14876
affects: Student, Teacher
release note: Added filtering and sorting options to assignment list.
test plan: See ticket
refs: MBL-17935
affects: Student
release note: Fixed downloaded files not being available in offline mode.

test plan:
- Have a course with a course file added to modules.
- Sync the course with files for offline mode.
- Go offline.
- Enter the course's Files menu.
- Check if the downloaded file displays in the file viewer.
- Go to Modules, test if the linked file in the module item it will display in offline mode.
- Smoke test if files are working in online mode.
* Fix startup crash

refs: MBL-18078
affects: Student, Teacher
release note: Fixed a startup crash which occurred on some devices.

test plan:

* Fix always visible Back Online banner
[ignore-commit-lint]
refs: MBL-18051
affects: Student, Teacher
release note: Fixed the end of inbox messages not being displayed in some cases.

test plan: See PR description
ndrsszsz and others added 12 commits January 21, 2025 14:19
affects: Student, Teacher, Parent
release note: None
test plan: VoiceOver should read Avatar image as button.
affects: Student, Teacher
release note: None
test plan: VoiceOver should announce the navigation bar title as header.
refs: MBL-18298
affects: Teacher
release note: None
test plan: All submission filter options should be displayed correctly even when the font size is set to the maximum.
[ignore-commit-lint]
[ignore-commit-lint]
refs: MBL-18544
affects: Student, Teacher
release note: Improved various filter screens.

test plan: See PR description
…r Course in the Database (#3078)

refs: MBL-18150
affects: Student, Teacher
release note: none
Student - Fix Grades screen scrolling issue
refs: MBL-18164
affects: Student
release note: Fixed a bug that caused Grades list to become unresponsive sometimes.
test plan: See ticket.
refs: MBL-18180
affects: Student
release note: Fixed external tool link being disabled in some cases.
refs: MBL-18306
affects: Student, Teacher
release note: None
test plan: No text should get cut off on EditCalendarEventScreen when font size is increased to the maximum.
[ignore-commit-lint]
@Ahmed-Naguib93 Ahmed-Naguib93 self-assigned this Jan 28, 2025
@Ahmed-Naguib93 Ahmed-Naguib93 changed the title [Horizon] Remove duplicate files in unit test files [Horizon] Remove duplicate files in unit test Jan 28, 2025
@inst-danger
Copy link
Contributor

inst-danger commented Jan 28, 2025

Horizon Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Jan 28, 2025

Fails
🚫 Build failed, skipping coverage check
❌ XCTest failed: TeacherTests/PostGradesPresenterTests/testAllGradesPosted
Asynchronous wait failed: Exceeded timeout of 0.5 seconds, with unfulfilled expectations: "expectation".
XCTAssertTrue failed

Generated by 🚫 dangerJS against a07ea59

@Ahmed-Naguib93 Ahmed-Naguib93 changed the title [Horizon] Remove duplicate files in unit test [Horizon] Update from master Jan 28, 2025
@reabbotted reabbotted self-requested a review January 29, 2025 23:27
@Ahmed-Naguib93 Ahmed-Naguib93 merged commit 7bbca24 into feature/horizon Jan 31, 2025
2 of 4 checks passed
@Ahmed-Naguib93 Ahmed-Naguib93 deleted the fix/horizon-fix-file-duplication branch January 31, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants