Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vertex.md #1321

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update vertex.md #1321

wants to merge 2 commits into from

Conversation

aryzle
Copy link

@aryzle aryzle commented Jan 27, 2025

Important

Remove redundant async def extract_user(): line in vertex.md.

  • Documentation:
    • Remove redundant async def extract_user(): line in vertex.md under the "Simple User Example (Async)" section.

This description was created by Ellipsis for 4f52b93. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4f52b93 in 16 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. docs/integrations/vertex.md:76
  • Draft comment:
    The removal of the duplicate async def extract_user(): is correct. Ensure there are no other duplicate or redundant code sections.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The PR removes a duplicate function definition, which is a good change. However, the code snippet should be checked for any other issues.
2. docs/integrations/vertex.md:73
  • Draft comment:
    Ensure that vertex.md is added to the mkdocs.yml file to include it in the documentation.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_1fYxK2fPooJG57D2


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Collaborator

@ivanleomk ivanleomk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for submitting this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants