fix: [lw-7632] fix rename nft folder feat #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatertomi
approved these changes
Feb 12, 2025
przemyslaw-wlodek
approved these changes
Feb 13, 2025
Comment on lines
+55
to
+57
| useEffect(() => { | ||
| setName(folderToRename?.name || ''); | ||
| }, [folderToRename?.name]); |
There was a problem hiding this comment.
Can it change in the meantime? Isn't useState(folderToRename?.name || '') enough?
There was a problem hiding this comment.
yes, this is exactly what is happening, drawer is rendered with visibility set to false, but useState(folderToRename?.name || '') is still called
vetalcore
force-pushed
the
fix/lw-7632-fix-rename-nft-folder
branch
from
30c73d1 to
fcbfb72
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes