Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [lw-12153] style nft folder to maintain its height if empty #1708

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Feb 12, 2025

Checklist

  • JIRA - LW-12153
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes

@vetalcore vetalcore self-assigned this Feb 12, 2025
@vetalcore vetalcore requested a review from a team as a code owner February 12, 2025 21:54
Copy link
Contributor

@przemyslaw-wlodek przemyslaw-wlodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some prettier issue to be solved + PR description :)

@vetalcore vetalcore force-pushed the fix/lw-12153-fix-empty-nft-folder-sizing branch from c234a78 to 2a3f74a Compare February 13, 2025 08:07
@vetalcore vetalcore changed the title fix: [lw-12153] fix empty nft folder sizing fix: [lw-12153] fix empty nft folder sizing on nft page Feb 13, 2025
@vetalcore vetalcore changed the title fix: [lw-12153] fix empty nft folder sizing on nft page fix: [lw-12153] style nft folder to maintain it's height if empty Feb 13, 2025
@vetalcore vetalcore changed the title fix: [lw-12153] style nft folder to maintain it's height if empty fix: [lw-12153] style nft folder to maintain its height if empty Feb 13, 2025
@vetalcore vetalcore merged commit 9ff3b74 into main Feb 13, 2025
30 checks passed
@vetalcore vetalcore deleted the fix/lw-12153-fix-empty-nft-folder-sizing branch February 13, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants