fix: [lw-12182] add autofocus for all password inputs #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ✅ test report for 2ebcdebf
|
vetalcore
force-pushed
the
feat/lw-12182-password-inputs-auto-focus
branch
from
3d8c82b to
3560ce0
Compare
przemyslaw-wlodek
approved these changes
Feb 7, 2025
| @@ -84,6 +89,8 @@ export const SignData = (): React.ReactElement => { | |||
| onSubmit={(e) => handleSubmit(e, password)} | |||
| error={validPassword === false} | |||
| errorMessage={t('browserView.transaction.send.error.invalidPassword')} | |||
| id={inputId} | |||
| autoFocus | |||
There was a problem hiding this comment.
I remember we had some problems with autoFocus when singing a regular transaction. Not sure if that's the case but maybe hook usage is enough?
There was a problem hiding this comment.
i've tested it locally, seems to be working just fine
let's see what would be the results of sdet review?
| // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/no-explicit-any | ||
| export const useAutoFocus = (inputRef: any, autoFocus?: boolean): void => { | ||
| export const useAutoFocus = <T extends HTMLInputElement | InputRef>( | ||
| inputRef: RefObject<T> | string, |
There was a problem hiding this comment.
Can we please rename it to inputRefOrId?
packages/staking/package.json
Outdated
| @@ -72,6 +72,7 @@ | |||
| "react-virtuoso": "^4.6.3", | |||
| "recharts": "^2.9.2", | |||
| "use-resize-observer": "^9.1.0", | |||
| "uuid": "^8.3.2", | |||
There was a problem hiding this comment.
Suggesting: Can we lift this to the top package.json?
vetalcore
force-pushed
the
feat/lw-12182-password-inputs-auto-focus
branch
2 times, most recently
from
8c4ce04 to
ad4ab25
Compare
vetalcore
force-pushed
the
feat/lw-12182-password-inputs-auto-focus
branch
from
ad4ab25 to
2ebcdeb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Use custom hook that queries input by id and calls
.focus()if found.Testing
nami mode is out of the scope since it was already working there.*
Screenshots
Attach screenshots here if implementation involves some UI changes