Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension): limit stored tx history size [LW-12227] #1696

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

przemyslaw-wlodek
Copy link
Contributor

Checklist


Proposed solution

Limit stored tx history size.

Testing

  1. Restore wallet using Lace version >= 1.18.2
  2. Update Lace to version in main branch
  3. Call await chrome.storage.local.get() and see how many transactions are stored
  4. Update Lace to version in this branch
  5. Redo step 3 and see only 10 transactions

Copy link

sonarqubecloud bot commented Feb 6, 2025

Copy link
Member

@rhyslbw rhyslbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Copy link
Contributor

@pczeglik-iohk pczeglik-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @przemyslaw-wlodek

@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Feb 6, 2025

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for f9d74c79

passed failed skipped flaky total result
Total 33 0 4 0 37

Co-authored-by: Piotr Czeglik <[email protected]>
Co-authored-by: Martynas Kazlauskas <[email protected]>
@przemyslaw-wlodek przemyslaw-wlodek force-pushed the fix/LW-12227-limit-default-tx-history-size branch from 4676184 to f9d74c7 Compare February 6, 2025 10:16
@przemyslaw-wlodek przemyslaw-wlodek changed the title fix(extension): limit stored tx history size fix(extension): limit stored tx history size [LW-12227] Feb 6, 2025
@przemyslaw-wlodek przemyslaw-wlodek merged commit f678922 into main Feb 6, 2025
28 checks passed
@przemyslaw-wlodek przemyslaw-wlodek deleted the fix/LW-12227-limit-default-tx-history-size branch February 6, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants