Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [lw-12102] log runtime extension events and version mismatch #1694

Merged
merged 3 commits into from
Feb 6, 2025
Merged

feat: [lw-12102] log runtime extension events and version mismatch #1694

merged 3 commits into from
Feb 6, 2025

Conversation

vetalcore
Copy link
Contributor

@vetalcore vetalcore commented Feb 5, 2025 •
edited by jira bot
Loading

Checklist

  • JIRA - LW-12102
  • Proper tests implemented
  • Screenshots added.

Proposed solution

  • Add console logs for all runtime.on* events in onUpdate.ts
  • On each UI load, compare application version with the one from the service worker
    • Expose new background api method to get application version
    • Log sentry error if version doesn’t match with the one from UI process

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Attach screenshots here if implementation involves some UI changes

@vetalcore vetalcore requested a review from mkazlauskas February 5, 2025 11:32
@vetalcore vetalcore self-assigned this Feb 5, 2025
@vetalcore vetalcore requested a review from a team as a code owner February 5, 2025 11:32
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Feb 5, 2025 •
edited
Loading

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 4cc62061

passed failed skipped flaky total result
Total 33 0 4 0 37 ✅

mkazlauskas
mkazlauskas requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See responses to your comments @vetalcore

@vetalcore vetalcore requested a review from mkazlauskas February 6, 2025 01:49
@vetalcore vetalcore force-pushed the feat/lw-12102-log-runtime-events-and-version-mismatch branch 2 times, most recently from b301df9 to 7f73ce9 Compare February 6, 2025 12:32
@vetalcore vetalcore force-pushed the feat/lw-12102-log-runtime-events-and-version-mismatch branch from 6151747 to 4cc6206 Compare February 6, 2025 13:37
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mirceahasegan
mirceahasegan approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @vetalcore ! 🧙‍♂️

@vetalcore vetalcore removed the request for review from mkazlauskas February 6, 2025 15:54
@vetalcore vetalcore merged commit 4396100 into main Feb 6, 2025
30 checks passed
@vetalcore vetalcore deleted the feat/lw-12102-log-runtime-events-and-version-mismatch branch February 6, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@mirceahasegan mirceahasegan mirceahasegan approved these changes

Assignees

@vetalcore vetalcore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vetalcore @pczeglik-iohk @mkazlauskas @mirceahasegan