feat: added prefer-node-builtin-imports rule #3024
Conversation
GoldStrikeArch
force-pushed
the
feat/prefer-node-protocol
branch
from
d728d5c
to
968e562
Compare
| @@ -17,6 +17,7 @@ module.exports = { | |||
| 'import/no-named-as-default': 'warn', | |||
| 'import/no-named-as-default-member': 'warn', | |||
| 'import/no-duplicates': 'warn', | |||
| 'import/prefer-node-builtin-imports': 'warn', | |||
There was a problem hiding this comment.
adding things to recommended is a breaking change
| @@ -0,0 +1,39 @@ | |||
| # import/prefer-node-builtin-imports | |||
There was a problem hiding this comment.
I’m not interested in a rule that solely pushes using the protocol - if anything, it’d be a rule that can be configured to require, or forbid, the protocol.
There was a problem hiding this comment.
@ljharb What config option should be from user's perspective? Just a boolean to toggle this? If yes then I don't see how is it different from simply have it on or off
There was a problem hiding this comment.
"off" is the current state - where you can have import 'fs' and import 'node:path' in the same file. One rule setting would error on the first one, and require node:fs. The other would error on the second one, and require path.
|
@GoldStrikeArch are you still interested in completing this PR? |
Yeah, forgot about this. I will try to finish it on this weekend |
Fix to this issue
Added a new rule
prefer-node-builtin-imports.All test cases are taken from eslint-plugin-unicorn_test