Google Sheets Integration #142
Conversation
VSydor
force-pushed
the
feature/google-sheets-integration
branch
from
21aa1bc
to
4254497
Compare
VSydor
changed the title
| @@ -343,7 +343,7 @@ protected String getAccessToken() throws Exception { | |||
| log.info("token expired; jwt={} now={}; refreshing...", jwt.getExpiresAt().getTime(), now); | |||
|
|
|||
| try { | |||
| TokenResponse tokenResponse = new RefreshTokenRequest(new NetHttpTransport(), new JacksonFactory(), | |||
| TokenResponse tokenResponse = new RefreshTokenRequest(new NetHttpTransport(), GsonFactory.getDefaultInstance(), | |||
There was a problem hiding this comment.
@VSydor Are we positive this won't break anything? There are caveats to how Jackson vs. Gson handle default mappings. IIRC, Jackson defaults to camelCase while Gson defaults to snake_case?
There was a problem hiding this comment.
Oh, good point - will double check this part.
There was a problem hiding this comment.
@brmeyer xero-java is using an older version of com.google.api-client:google-api-client lib (same lib required for google sheets integration)
I think the best we can do is to upgrade the version of xero java (use the newest one) that relies on the most recent version of google-api-client.
Updated nucleus-parent to use most recent version of xero-java:
impactupgrade/nucleus-parent#8
There was a problem hiding this comment.
@VSydor Forgive me for not remembering this: since nucleus-parent is updated, do we still need this switch to Gson in Xero?
There was a problem hiding this comment.
Short answer is: yes - we do
Long one:
Both Google Sheets lib (google-api-services-sheets) and Xero lib (xero-java) depend on (google-oauth-client)
Sheets is using (1.34.1) and Xero uses (1.23.0)
We either need to update xero lib version (will also use newer version of google-auth), or just update the code to use Sheets version of google auth (Gson instead of Jackson)
|
|
||
| private final Sheets sheets; | ||
|
|
||
| public GoogleSheetsClient(EnvironmentConfig.GoogleSheets googleSheetsConfig) throws GeneralSecurityException, IOException { |
There was a problem hiding this comment.
Can you detail for us how all these details are initially found? Do we need an Oauth connection process in Portal? Does it require a Google app?
There was a problem hiding this comment.
Requires connected app in Google Cloud and service account with granted access to the given spreadsheet.
I will add these details as a comment in the code.
VSydor
force-pushed
the
feature/google-sheets-integration
branch
from
4254497
to
cce36e6
Compare
Depends on:
impactupgrade/nucleus-parent#8