feat(web): Face merging utility #15306
Open
+403
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you include some screenshots? |
|
|
FortStatement
force-pushed
the
merge-utility
branch
2 times, most recently
from
7dd4cbf to
963b89b
Compare
FortStatement
force-pushed
the
merge-utility
branch
from
963b89b to
d9c2f55
Compare
Crazytieguy
reviewed
Jan 13, 2025
Comment on lines
77
to
88
| onMount(async () => { | ||
| const { people: similarPeople } = await getAllPeople({ | ||
| withHidden: false, | ||
| closestPersonId: data.person.id, | ||
| }); | ||
| // Filter out the person we searched for since we don't want to merge with themselves | ||
| const selfIndex = similarPeople.findIndex((person) => person.id === data.person.id); | ||
| if (selfIndex !== -1) { | ||
| similarPeople.splice(selfIndex, 1); | ||
| } | ||
| people = similarPeople; | ||
| }); |
There was a problem hiding this comment.
I think you probably want to fetch this in merge-faces/[personId]/+page.ts, and you'll have it in the data prop. That's the recommended/ideomatic way of fetching data for a page in sveltekit, and you won't need the onMount.
| </Button> | ||
| </div> | ||
| {/snippet} | ||
| <div class="flex flex-col gap-4"> |
There was a problem hiding this comment.
I think this div doesn't accomplish anything, it looks like a flex container but it only has one child
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya, I had a lot of people with some pictures that had faces not quite identifiable enough to match automatically.
This adds a utility to choose a person and see all the identities most similar to them, then select any to merge into the main identity.
It was very useful to me, let me know if anything can be done so it'd be useful for others!