smcr/smcd: add statistics on sndbufs/RMBs usage #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, any comments on this PR ? Thanks! :) |
Geywn
changed the title
|
Hi @Geywn I'm looking into it and review it. |
JanKarcher
suggested changes
Aug 29, 2024
smctools_common.h
Outdated
Comment on lines
143
to
145
| SMC_NLA_LGR_R_NET_COOKIE, /* u64 */ | ||
| SMC_NLA_LGR_R_PAD, /* flag */ | ||
| SMC_NLA_LGR_R_BUF_TYPE, /* u8 */ |
There was a problem hiding this comment.
They are not used, yet. I'm fine with them being added in order to be complete.
Please use tabs infront of the comments instead of spaces for consistency.
smctools_common.h
Outdated
Comment on lines
181
to
184
| SMC_NLA_LGR_D_EXT_GID, /* u64 */ | ||
| SMC_NLA_LGR_D_PEER_EXT_GID, /* u64 */ | ||
| SMC_NLA_LGR_D_SNDBUF_ALLOC, /* uint */ | ||
| SMC_NLA_LGR_D_DMB_ALLOC, /* uint */ |
added 4 commits
September 4, 2024 10:07
The kernel introduced some new smc netlink enum values, so add them to smctool_common.h as well. Signed-off-by: Wen Gu <[email protected]>
The NLA_UINT attribute type is introduced for variable-length integers, whose length are 32bits or 64bits. So add appropriate functions to get NLA_UINT attributes. Signed-off-by: Wen Gu <[email protected]>
The kernel introduced statistics on the amount of sndbufs/RMBs maintained by the smcr/smcd linkgroup. So show the information in smcr/smcd linkgroup detailed output. Signed-off-by: Wen Gu <[email protected]>
The kernel introduced statistics on the amount of sndbuf/RMBs in use by smcr/smcd connections. So show the information in smcr/smcd stats. Signed-off-by: Wen Gu <[email protected]>
Geywn
force-pushed
the
diagnose/memory-v2
branch
from
995baf0
to
845ab35
Compare
|
Hi, Jan. I have fixed the tab things. Thanks! |
|
@Geywn looks good to me now. We'll include the changes in the next release of smc-tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel introduced statistics on the amount of sndbufs/RMBs maintained
by the linkgroups and being used by connections. So show the information in
smc{r|d} -d landsmc{r|d} -d s.And before that, synchronize the latest smc netlink attribute enum values and
introduce a helper to get new-added netlink attribute type
NLA_UINT.